refactor(traverse)!: remove TraverseCtx::clone_identifier_reference
#7266
+12
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
github-actions
bot
added
A-transformer
overlookmotel
force-pushed
the
11-13-refactor_traverse_remove_traversectx_clone_identifier_reference_
branch
from
aacef59
to
57cbb85
Compare
CodSpeed Performance ReportMerging #7266 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
11-13-feat_traverse_introduce_maybeboundidentifier_
branch
from
02dcd21
to
c2d693a
Compare
overlookmotel
force-pushed
the
11-13-refactor_traverse_remove_traversectx_clone_identifier_reference_
branch
from
57cbb85
to
7a6f4a9
Compare
Merge activity
|
…#7266) Remove `TraverseCtx::clone_identifier_reference`. This API encourages unnecessary repeated lookups of the `SymbolId` for a reference. It is preferable to use `MaybeBoundIdentifier` which only looks up the `SymbolId` once.
Boshen
force-pushed
the
11-13-feat_traverse_introduce_maybeboundidentifier_
branch
from
c2d693a
to
8c754b1
Compare
Boshen
force-pushed
the
11-13-refactor_traverse_remove_traversectx_clone_identifier_reference_
branch
from
7a6f4a9
to
e84ea2c
Compare
Base automatically changed from
11-13-feat_traverse_introduce_maybeboundidentifier_
to
main
November 13, 2024 15:17
graphite-app
bot
deleted the
11-13-refactor_traverse_remove_traversectx_clone_identifier_reference_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
TraverseCtx::clone_identifier_reference.This API encourages unnecessary repeated lookups of the
SymbolIdfor a reference. It is preferable to useMaybeBoundIdentifierwhich only looks up theSymbolIdonce.